-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: improve Coscheduling PreFilter status #1861
scheduler: improve Coscheduling PreFilter status #1861
Conversation
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
+ Coverage 67.26% 67.28% +0.02%
==========================================
Files 407 407
Lines 45644 45644
==========================================
+ Hits 30701 30711 +10
+ Misses 12728 12722 -6
+ Partials 2215 2211 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Ⅰ. Describe what this PR does
If some Pods with the same PodGroup CRD object are created and scheduling fails, the coscheduling PreFilter returns framework.Error to stop preemption, but this is not the best option. It should return framework.UnschedulableAndUnresolvable.
framework.Error is special in the scheduler. It represents an internal service exception. We can determine whether the scheduler is healthy by identifying whether there are Errors, but a plugin that frequently returns Errors will prevent us from identifying exceptions.
Ⅱ. Does this pull request fix one issue?
fix #1860
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test